[PATCH v2 2/3] d2d1: Implement ID2D1Bitmap1::Unmap().
Dmitry Timoshkov
dmitry at baikal.ru
Fri May 27 04:21:09 CDT 2022
Nikolay Sivov <nsivov at codeweavers.com> wrote:
> > @@ -66,6 +66,8 @@ static ULONG STDMETHODCALLTYPE d2d_bitmap_Release(ID2D1Bitmap1 *iface)
> >
> > if (!refcount)
> > {
> > + if (bitmap->staging_resource)
> > + ID2D1Bitmap1_Unmap(iface);
> > if (bitmap->srv)
> > ID3D11ShaderResourceView_Release(bitmap->srv);
> > if (bitmap->rtv)
> Is it necessary to unmap?
Probably not, although I was getting errors from wined3d with ::Unmap()
being a stub. Perhaps that was a result of the staging texture leak.
Many thanks for the helpful reviews.
--
Dmitry.
More information about the wine-devel
mailing list