[PATCH 0/6] MR159: ntdll: More heap code cleanup.

Sven Baars (@sbaars) wine at gitlab.winehq.org
Tue May 31 04:35:40 CDT 2022


Sven Baars (@sbaars) commented about dlls/kernel32/tests/heap.c:
>      if (flags & HEAP_TAIL_CHECKING_ENABLED)
>      {
>          /* Windows doesn't do tail checking on large blocks */
> -        ok( p[large_size] == 0xab || broken(p[large_size] == 0), "wrong data %x\n", p[large_size] );
> -        ok( p[large_size+1] == 0xab || broken(p[large_size+1] == 0), "wrong data %x\n", p[large_size+1] );
> -        ok( p[large_size+2] == 0xab || broken(p[large_size+2] == 0), "wrong data %x\n", p[large_size+2] );
> +        ok( p[large_size] == 0, "wrong data %x\n", p[large_size] );
> +        ok( p[large_size + 1] == 0, "wrong data %x\n", p[large_size + 1] );
> +        ok( p[large_size + 2] == 0, "wrong data %x\n", p[large_size + 2] );
>          if (p[large_size] == 0xab)
Isn't this if statement unreachable now according to the test above?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/159#note_1422



More information about the wine-devel mailing list