Move 16-bit COMM stuff to USER, where it belongs

Patrik Stridvall ps at leissner.se
Mon Jun 18 03:44:49 CDT 2001


> Changelog:
>     Dmitry Timoshkov <dmitry at codeweavers.com>
>     Move 16-bit COMM stuff to USER, where it belongs.

Good idea, but...

> diff -u cvs/hq/wine/dlls/user/Makefile.in wine/dlls/user/Makefile.in
> --- cvs/hq/wine/dlls/user/Makefile.in	Sat Jun  2 17:22:50 2001
> +++ wine/dlls/user/Makefile.in	Mon Jun 18 12:24:07 2001
> @@ -10,6 +10,7 @@
>  C_SRCS = \
>  	bidi16.c \
>  	cache.c \
> +	comm.c \
>  	ddeml.c \
>  	display.c \
>  	exticon.c \
> diff -u cvs/hq/wine/dlls/user/comm.c wine/dlls/user/comm.c
> --- /dev/null	Wed May  6 05:32:27 1998
> +++ wine/dlls/user/comm.c	Mon Jun 18 12:54:03 2001
[snip]

... perhaps we should call it comm16.c instead of comm.c since
it seems to only contain 16-bit stuff.

Correct me if I'm wrong but some years(?) ago we discussed
this a came to the conclusion 16-bit stuff should be in
seperate files but that it was to much work for little gain
so no real effort was made. However for new files we really
should follow this policy.

PS. No need to supply a new patch. Alexandre can easily rename
the file and edit the Makefile.in if he agrees.




More information about the wine-patches mailing list