PROFILE_CopyEntry fix

François Gouget fgouget at codeweavers.com
Fri May 4 22:18:21 CDT 2001


Changelog:

   François Gouget <fgouget at codeweavers.com>

 * files/profile.c
   Potential buffer overflow in PROFILE_CopyEntry

-- 
François Gouget
fgouget at codeweavers.com
-------------- next part --------------
Index: files/profile.c
===================================================================
RCS file: /home/cvs/wine/wine/files/profile.c,v
retrieving revision 1.47
diff -u -r1.47 profile.c
--- files/profile.c	2001/03/23 19:13:23	1.47
+++ files/profile.c	2001/05/05 02:04:04
@@ -120,9 +120,11 @@
             lstrcpynA(env_val, p + 2, min( sizeof(env_val), (int)(p2-p)-1 ));
             if ((env_p = getenv( env_val )) != NULL)
             {
+                int buffer_len;
                 lstrcpynA( buffer, env_p, len );
-                buffer += strlen( buffer );
-                len -= strlen( buffer );
+                buffer_len = strlen( buffer );
+                buffer += buffer_len;
+                len -= buffer_len;
             }
             p = p2 + 1;
         }


More information about the wine-patches mailing list