Unnecessary imports?

Francois Gouget fgouget at free.fr
Mon Jan 21 02:18:57 CST 2002



   Compiling Wine I noticed many warnings saying that the dlls we import
are not used. Is there any reason to still import them? If so, then why
does winebuild complain? And how does one get rid of the warnings? But
if these imports truely are unnecessary, then here is a patch to remove
them.


Changelog:

 * dlls/crypt32/crypt32.spec,
   dlls/dciman32/dciman32.spec,
   dlls/icmp/icmp.spec,
   dlls/imm32/imm32.spec,
   dlls/msrle32/msrle32.spec,
   dlls/oledlg/oledlg.spec,
   dlls/rpcrt4/rpcrt4.spec

   Remove unnecessary imports



--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
                Linux: It is now safe to turn on your computer.
-------------- next part --------------
Index: dlls/crypt32/crypt32.spec
===================================================================
RCS file: /home/wine/wine/dlls/crypt32/crypt32.spec,v
retrieving revision 1.1
diff -u -r1.1 crypt32.spec
--- dlls/crypt32/crypt32.spec	2002/01/10 19:41:12	1.1
+++ dlls/crypt32/crypt32.spec	2002/01/21 05:40:48
@@ -1,8 +1,6 @@
 name crypt32
 type win32
 
-import advapi32.dll
-import kernel32.dll
 import ntdll.dll
 
 debug_channels ()
Index: dlls/dciman32/dciman32.spec
===================================================================
RCS file: /home/wine/wine/dlls/dciman32/dciman32.spec,v
retrieving revision 1.6
diff -u -r1.6 dciman32.spec
--- dlls/dciman32/dciman32.spec	2001/02/12 01:18:42	1.6
+++ dlls/dciman32/dciman32.spec	2002/01/21 05:40:48
@@ -1,7 +1,6 @@
 name	dciman32
 type	win32
 
-import	kernel32.dll
 import	ntdll.dll
 
 @ stub    DCIBeginAccess
Index: dlls/icmp/icmp.spec
===================================================================
RCS file: /home/wine/wine/dlls/icmp/icmp.spec,v
retrieving revision 1.4
diff -u -r1.4 icmp.spec
--- dlls/icmp/icmp.spec	2000/11/05 04:53:08	1.4
+++ dlls/icmp/icmp.spec	2002/01/19 19:26:08
@@ -1,7 +1,6 @@
 name icmp
 type win32
 
-import kernel32.dll
 import ntdll.dll
 
 debug_channels (icmp)
Index: dlls/imm32/imm32.spec
===================================================================
RCS file: /home/wine/wine/dlls/imm32/imm32.spec,v
retrieving revision 1.9
diff -u -r1.9 imm32.spec
--- dlls/imm32/imm32.spec	2000/12/18 03:51:16	1.9
+++ dlls/imm32/imm32.spec	2002/01/21 05:40:49
@@ -4,7 +4,7 @@
 
 import	user32.dll
 # NOTE: gdi32.dll will be required for implementing IME global class.
-import	gdi32.dll
+#import	gdi32.dll
 import	advapi32.dll
 import	kernel32.dll
 import	ntdll.dll
Index: dlls/msrle32/msrle32.spec
===================================================================
RCS file: /home/wine/wine/dlls/msrle32/msrle32.spec,v
retrieving revision 1.1
diff -u -r1.1 msrle32.spec
--- dlls/msrle32/msrle32.spec	2001/11/06 00:41:07	1.1
+++ dlls/msrle32/msrle32.spec	2002/01/19 19:26:08
@@ -4,7 +4,6 @@
 
 import winmm.dll
 import user32.dll
-import kernel32.dll
 import ntdll.dll
 
 debug_channels(msrle32)
Index: dlls/oledlg/oledlg.spec
===================================================================
RCS file: /home/wine/wine/dlls/oledlg/oledlg.spec,v
retrieving revision 1.6
diff -u -r1.6 oledlg.spec
--- dlls/oledlg/oledlg.spec	2001/07/08 22:32:51	1.6
+++ dlls/oledlg/oledlg.spec	2002/01/19 19:26:10
@@ -1,7 +1,6 @@
 name	oledlg
 type	win32
 
-import	kernel32.dll
 import	ntdll.dll
 
 debug_channels (ole)
Index: dlls/rpcrt4/rpcrt4.spec
===================================================================
RCS file: /home/wine/wine/dlls/rpcrt4/rpcrt4.spec,v
retrieving revision 1.10
diff -u -r1.10 rpcrt4.spec
--- dlls/rpcrt4/rpcrt4.spec	2002/01/06 19:08:47	1.10
+++ dlls/rpcrt4/rpcrt4.spec	2002/01/19 19:26:11
@@ -2,7 +2,6 @@
 type	win32
 init	RPCRT4_LibMain
 
-import	kernel32.dll
 import	ntdll.dll
 
 debug_channels (ole)


More information about the wine-patches mailing list