Missing ReleaseWndPtr in CreateDesktopWindow

Francois Gouget fgouget at free.fr
Sat May 18 21:22:09 CDT 2002


It may not matter much but I believe there is a missing
WIN_ReleaseWndPtr in WIN_CreateDesktopWindow. The reason why it does
not matter much is because it's in an error case which seems quite
fatal. But still...


Changelog:

 * windows/win.c

   Add missing WIN_ReleaseWndPtr in WIN_CreateDesktopWindow



--
Francois Gouget         fgouget at free.fr        http://fgouget.free.fr/
                      Computers are like airconditioners
                They stop working properly if you open WINDOWS


Index: windows/win.c
===================================================================
RCS file: /home/wine/wine/windows/win.c,v
retrieving revision 1.182
diff -u -r1.182 win.c
--- windows/win.c	6 May 2002 20:11:19 -0000	1.182
+++ windows/win.c	19 May 2002 02:14:22 -0000
@@ -794,7 +794,11 @@
     WIN_SetRectangles( hwndDesktop, &rect, &rect );
     WIN_SetStyle( hwndDesktop, WS_VISIBLE | WS_CLIPCHILDREN | WS_CLIPSIBLINGS );

-    if (!USER_Driver.pCreateWindow( hwndDesktop, &cs, FALSE )) return FALSE;
+    if (!USER_Driver.pCreateWindow( hwndDesktop, &cs, FALSE ))
+    {
+        WIN_ReleaseWndPtr( pWndDesktop );
+        return FALSE;
+    }

     pWndDesktop->flags |= WIN_NEEDS_ERASEBKGND;
     WIN_ReleaseWndPtr( pWndDesktop );




More information about the wine-patches mailing list