listview K9

Dimitrie O. Paun dpaun at rogers.com
Fri Oct 4 18:17:01 CDT 2002


ChangeLog
  Fix onwer-draw REPORT for broken apps.
  (With help from Alexandre Julliard <julliard at winehq.com>)

--- dlls/comctl32/listview.c.K8	Fri Oct  4 14:35:54 2002
+++ dlls/comctl32/listview.c	Fri Oct  4 19:13:50 2002
@@ -3330,8 +3330,13 @@
             OffsetRect(&dis.rcItem, ptOrig.x, 0);
 
 	    TRACE("item=%s, rcItem=%s\n", debuglvitem_t(&item, TRUE), debugrect(&dis.rcItem));
-            if (SendMessageW(GetParent(infoPtr->hwndSelf), WM_DRAWITEM, dis.CtlID, (LPARAM)&dis))
-		continue;
+            SendMessageW(GetParent(infoPtr->hwndSelf), WM_DRAWITEM, dis.CtlID, (LPARAM)&dis);
+	    /* In theory we should do the default drawing if WM_DRAWITEM 
+	     * returns FALSE but, in the words of Larry McVoy, in practice
+	     * theory is different than practice, and hence there are 
+	     * important apps out there that depend on no default drawing
+	     * in LVS_OWNERDRAWFIXED. So we always skip to the next item. */
+	    continue;
         }
 	
 	/* compute the full select rectangle, if needed */





More information about the wine-patches mailing list