Listbox fix

Dimitrie O. Paun dpaun at rogers.com
Mon Sep 9 11:45:23 CDT 2002


It bothered me to no end that while using ControlSpy,
the listboxes displayed in the style window where one
row larger than they should be.

Investigating the problem, I found that Windows displays
1 pixel less between listbox rows than we do. Since we're
basing the item height on the font height, I thought that we
were calculatining the font height incorrectly. Nope. We just
need to set the item height in the list box one less then the
font height. This fixes the problems I was noticing before.

ChangeLog
  Fix item height setting in listboxes.

Index: controls/listbox.c
===================================================================
RCS file: /var/cvs/wine/controls/listbox.c,v
retrieving revision 1.85
diff -u -r1.85 listbox.c
--- controls/listbox.c	4 Sep 2002 19:37:01 -0000	1.85
+++ controls/listbox.c	9 Sep 2002 16:26:58 -0000
@@ -1255,8 +1255,8 @@
     if (oldFont) SelectObject( hdc, oldFont );
     ReleaseDC( hwnd, hdc );
     if (!IS_OWNERDRAW(descr))
-        LISTBOX_SetItemHeight( hwnd, descr, 0, tm.tmHeight, FALSE );
-    return tm.tmHeight ;
+        LISTBOX_SetItemHeight( hwnd, descr, 0, tm.tmHeight - 1, FALSE );
+    return tm.tmHeight - 1;
 }
 
 




More information about the wine-patches mailing list