mdi: Don't use SWP_FRAMECHANGED from WM_MDISETMENU

Andrew de Quincey adq_dvb at lidskialf.net
Thu Dec 4 08:56:46 CST 2003


This causes bad performance problems in IDA.

Looking at the docs on MSDN for WM_MDISETMENU, it says "After sending this 
message, an application must call the DrawMenuBar function to update the menu 
bar". Which implies that the application is in charge of telling the menu bar 
to redraw, meaning the use of SWP_FRAMECHANGED is superfluous.

However, SetMenu() is used non by MDI menus as well, which DO expect the menu 
to be updated automatically (MSDN: "The window is redrawn to reflect the menu 
change"), which means it can't just be removed.

The way I've fixed it is the neatest way I could think of. If someone can 
suggest a better method please do, and I'll sort it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wine-mdi-nomenuupdate.patch
Type: text/x-diff
Size: 2447 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20031204/412375bf/wine-mdi-nomenuupdate.bin


More information about the wine-patches mailing list