Remove bogus error condition in loader.c

Troy Rollo wine at troy.rollo.name
Tue Jun 24 20:31:57 CDT 2003


This patch removes an error condition in loader.c that shouldn't be there (or 
at least if it indicates a problem, the problem is elsewhere and using this 
error condition is worse than leaving the existing problem alone). The error 
relates to attempts to call LoadLibrary on an executable (.EXE) - Wine fails 
attempts to do this. While it's unusual to do this, it's not illegal, and it 
can be useful to do so in some cases, such as extracting resources from one 
EXE file for use at runtime by another.

As an example, we do this as part of our development process to generate 
localisation related files and to check that dialogs conform to our coding 
standards.

diff -u -r1.23 loader.c
--- dlls/ntdll/loader.c	7 Apr 2003 23:27:55 -0000	1.23
+++ dlls/ntdll/loader.c	25 Jun 2003 01:18:33 -0000
@@ -381,7 +381,6 @@
         if (!(nt->FileHeader.Characteristics & IMAGE_FILE_DLL))
         {
             if (!exe_modref) exe_modref = wm;
-            else FIXME( "Trying to load second .EXE file: %s\n", filename );
         }
         else wm->ldr.Flags |= LDR_IMAGE_IS_DLL;
     }
I




More information about the wine-patches mailing list