PATCH: Implement some missing stuffs (reformated)

BigBun fbiggun at hotmail.com
Sun Mar 23 03:30:26 CST 2003


Hi all.

   While running one of my favorite app under wine, i noticed messages from
wine revealing some unimplmented stuffs that my app needs. I correct these
unimplemted stuffs and hope these "add-ons" could be useful for other apps.
Here are the summary of all i have done.


* Implementing a default behavior for SPI_GETGRADIENTCAPTIONS flag in
SystemParametersInfoA.

    Each time this flag is querying, SystemParametersInfoA returns false as
response. As of MSDN doc, this flag is not supported by WinNT and Win95. But
instead of returning false each time SPI_GETGRADIENTCAPTIONS is queryed, i
think that the behavior of the function could be improved. For instance
checking which windows version wine is currently emulated, can tell the
right behavior to take.
   I also add a fixme message telling the default behavior for the flag.

* Adding call to TabCtrl_SetPadding in TAB_WindowProc.

                                   Stephan BEUZE

Changelog:
  Implementing a default behavior for SPI_GETGRADIENTCAPTIONS flag in
SystemParametersInfoA.
  Adding call to TabCtrl_SetPadding in TAB_WindowProc.

Index: dlls/comctl32/tab.c
===================================================================
RCS file: /home/wine/wine/dlls/comctl32/tab.c,v
retrieving revision 1.78
diff -u -r1.78 tab.c
--- dlls/comctl32/tab.c 17 Mar 2003 04:43:26 -0000 1.78
+++ dlls/comctl32/tab.c 23 Mar 2003 08:52:10 -0000
@@ -3075,7 +3075,7 @@
       return 0;

     case TCM_SETPADDING:
-      FIXME("Unimplemented msg TCM_SETPADDING\n");
+      TabCtrl_SetPadding (hwnd, wParam, lParam);
       return 0;

     case TCM_GETROWCOUNT:
Index: windows/sysparams.c
===================================================================
RCS file: /home/wine/wine/windows/sysparams.c,v
retrieving revision 1.49
diff -u -r1.49 sysparams.c
--- windows/sysparams.c 19 Feb 2003 22:04:46 -0000 1.49
+++ windows/sysparams.c 23 Mar 2003 08:52:12 -0000
@@ -1734,7 +1734,14 @@
     WINE_SPI_FIXME(SPI_SETCOMBOBOXANIMATION);   /* 0x1005  _WIN32_WINNT >=
0x500 || _WIN32_WINDOW > 0x400 */
     WINE_SPI_FIXME(SPI_GETLISTBOXSMOOTHSCROLLING);/* 0x1006  _WIN32_WINNT
>= 0x500 || _WIN32_WINDOW > 0x400 */
     WINE_SPI_FIXME(SPI_SETLISTBOXSMOOTHSCROLLING);/* 0x1007  _WIN32_WINNT
>= 0x500 || _WIN32_WINDOW > 0x400 */
-    WINE_SPI_FIXME(SPI_GETGRADIENTCAPTIONS);    /* 0x1008  _WIN32_WINNT >=
0x500 || _WIN32_WINDOW > 0x400 */
+
+    case SPI_GETGRADIENTCAPTIONS:    /* 0x1008  _WIN32_WINNT >= 0x500 ||
_WIN32_WINDOW > 0x400 */
+    {
+        FIXME("case SPI_GETGRADIENTCAPTIONS always return false\n");
+        *(BOOL *)pvParam = FALSE;
+ break;
+    }
+
     WINE_SPI_FIXME(SPI_SETGRADIENTCAPTIONS);    /* 0x1009  _WIN32_WINNT >=
0x500 || _WIN32_WINDOW > 0x400 */
     WINE_SPI_FIXME(SPI_GETKEYBOARDCUES);        /* 0x100A  _WIN32_WINNT >=
0x500 || _WIN32_WINDOW > 0x400 */
     WINE_SPI_FIXME(SPI_SETKEYBOARDCUES);        /* 0x100B  _WIN32_WINNT >=
0x500 || _WIN32_WINDOW > 0x400 */
Index: windows/win.c
===================================================================
RCS file: /home/wine/wine/windows/win.c,v
retrieving revision 1.216
diff -u -r1.216 win.c
--- windows/win.c 14 Mar 2003 04:11:17 -0000 1.216
+++ windows/win.c 23 Mar 2003 08:52:13 -0000
@@ -2311,7 +2311,7 @@

     /* when window belongs to other process, don't send a message */
     if (nMaxCount <= 0) return 0;
-    get_server_window_text( hwnd, lpString, nMaxCount );
+    get_server_window_text( hwnd, lpString, nMaxCount );
     return strlenW(lpString);
 }



-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 2542 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20030323/9220d652/patch.obj


More information about the wine-patches mailing list