rpc_M_00 fix a bug in NdrSendReceive

Gregory M. Turner gmturner007 at ameritech.net
Mon Oct 20 18:47:16 CDT 2003


LICENSE: Bugroff

CHANGELOG:

* dlls/rpcrt4: ndr_midl.c:
  Greg Turner <gmturner007 at ameritech.net>,
- remove an erroneous check in NdrSendReceive
- change fixmes

--
diff -ur --minimal --exclude-from=/home/greg/bin/winetreediff_excl ../wine.vanilla/dlls/rpcrt4/ndr_midl.c ./dlls/rpcrt4/ndr_midl.c
--- ../wine.vanilla/dlls/rpcrt4/ndr_midl.c	2003-09-07 09:01:24.000000000 -0500
+++ ./dlls/rpcrt4/ndr_midl.c	2003-10-20 18:31:15.000000000 -0500
@@ -266,16 +266,13 @@
     ERR("RPC Message not present in stub message.  No action taken.\n");
     return NULL;
   }
-  if (stubmsg->RpcMsg->Buffer != buffer) {
-    ERR("Ambiguous buffer doesn't match rpc message buffer.  No action taken.\n");
-    return NULL;
-  }
 
-  /* not sure where MS does this; for now I'll stick it here */
+  /* FIXME: Seems wrong.  Where should this really come from, and when? */
   stubmsg->RpcMsg->DataRepresentation = NDR_LOCAL_DATA_REPRESENTATION;
 
   if (I_RpcSendReceive(stubmsg->RpcMsg) != RPC_S_OK) {
     WARN("I_RpcSendReceive did not return success.\n");
+    /* FIXME: raise exception? */
   }
 
   /* FIXME: is this the right return value? */
-- 
gmt

"class 'SfxPoolCancelManager' only defines a
 private destructor and has no friends"
   -- gcc, resorting to unnecessary character attacks




More information about the wine-patches mailing list