RESEND: [Toolbar] Fixes for IE Favourites 'menu'

Robert Shearman R.J.Shearman at
Tue Oct 28 10:09:25 CST 2003

Anything wrong with this patch or did it just slip through the cracks?

----------  Forwarded Message  ----------

Subject: [Toolbar] Fixes for IE Favourites 'menu'
Date: Sun, 19 Oct 2003 17:08:16 +0100
From: Robert Shearman <R.J.Shearman at>
To: wine-patches at


This patch fixes a number of issues with the Internet Explorer favourites
'menu'. The menu is really a customised toolbar, but there were a number of
1. The (empty) entries weren't drawn as disabled. This was because our
control wasn't using the states that had been changed by the WM_NOTIFY
message at the start of drawing the button. According to MSDN, an app can do
2. Disabled buttons can become "hot", but they are just not drawn differently
(unless TBCDRF_HILITEHOTTRACK is specified).
3. The bitmaps weren't drawn properly. This was because the image list
was set with a custom ID, but the custom ID for the button was set after the
default image list (with 0 ID) had been retrieved (as it was I_IMAGECALLBACK)
and so drawing was aborted.


- Use the style returned in custom draw structure to draw the button, as apps
may modify the style this way
- Disabled buttons can become hot
- Retrieve image list for drawing after getting image list ID (in


-------------- next part --------------
A non-text attachment was scrubbed...
Name: toolbar.diff
Type: text/x-diff
Size: 12665 bytes
Desc: not available
Url :

More information about the wine-patches mailing list