typelib: GetVarIndexOfMemId

Huw D M Davies h.davies1 at physics.ox.ac.uk
Mon Dec 6 11:32:50 CST 2004


        Huw Davies <huw at codeweavers.com>
        Fix return value of GetVarIndexOfMemId
-- 
Huw Davies
huw at codeweavers.com
Index: dlls/oleaut32/typelib.c
===================================================================
RCS file: /home/wine/wine/dlls/oleaut32/typelib.c,v
retrieving revision 1.129
diff -u -p -p -r1.129 typelib.c
--- dlls/oleaut32/typelib.c	2 Dec 2004 19:58:07 -0000	1.129
+++ dlls/oleaut32/typelib.c	6 Dec 2004 18:24:27 -0000
@@ -5280,15 +5280,14 @@ static HRESULT WINAPI ITypeInfo2_fnGetVa
     for(i=0, pVarInfo=This->varlist; pVarInfo &&
             memid != pVarInfo->vardesc.memid; i++, pVarInfo=pVarInfo->next)
         ;
-    if(pVarInfo){
-        *pVarIndex=i;
-        result= S_OK;
-    }else{
-        *pVarIndex=0;
-        result=E_INVALIDARG;
-    }
+    if(pVarInfo) {
+        *pVarIndex = i;
+        result = S_OK;
+    } else
+        result = TYPE_E_ELEMENTNOTFOUND;
+
     TRACE("(%p) memid 0x%08lx -> %s\n", This,
-          memid, SUCCEEDED(result)? "SUCCES":"FAILED");
+          memid, SUCCEEDED(result) ? "SUCCESS" : "FAILED");
     return result;
 }
 



More information about the wine-patches mailing list