questionable code

[Huw D M Davies]

On Sat, Dec 11, 2004 at 11:37:11AM +0100, Eric Pouech wrote:
> still toying with various compilers, here's two new questions (to whom it 
> may concern):
> 
> **** dlls/gdi/freetype.c line 1467
> the test for "(offset < 0)" is always false. I'm not sure changing it into 
> "offset == -1" is the right solution.

Looks good to me.

        Huw Davies <huw at codeweavers.com>
        Fix always false test.  Spotted by Eric Pouech
Index: dlls/gdi/freetype.c
===================================================================
RCS file: /home/wine/wine/dlls/gdi/freetype.c,v
retrieving revision 1.76
diff -u -p -r1.76 freetype.c
--- dlls/gdi/freetype.c	18 Oct 2004 19:38:30 -0000	1.76
+++ dlls/gdi/freetype.c	11 Dec 2004 12:19:59 -0000
@@ -1464,7 +1464,7 @@ static LONG load_VDMX(GdiFont font, LONG
 	    }
     }
 
-    if(offset < 0) {
+    if(offset == -1) {
 	FIXME("No suitable ratio found\n");
 	return ppem;
     }