ShowWindow shouldn't fix SWP_ flags, it's the job of SetWindowPos

Dmitry Timoshkov dmitry at baikal.ru
Fri Jun 18 04:40:12 CDT 2004


Hello,

Changelog:
    Dmitry Timoshkov <dmitry at codeweavers.com>
    ShowWindow shouldn't fix SWP_ flags, it's the job of SetWindowPos.

--- cvs/hq/wine/dlls/x11drv/winpos.c	2004-06-15 18:53:53.000000000 +0900
+++ wine/dlls/x11drv/winpos.c	2004-06-18 18:10:53.000000000 +0900
@@ -1316,15 +1316,6 @@ BOOL X11DRV_ShowWindow( HWND hwnd, INT c
             if (wasVisible) goto END;
 
 	    swp |= SWP_SHOWWINDOW | SWP_NOSIZE | SWP_NOMOVE;
-
-	    /*
-	     * ShowWindow has a little peculiar behavior that if the
-	     * window is already the topmost window, it will not
-	     * activate it.
-	     */
-	    if (GetTopWindow(NULL)==hwnd && (wasVisible || GetActiveWindow() == hwnd))
-	      swp |= SWP_NOACTIVATE;
-
 	    break;
 
 	case SW_SHOWNOACTIVATE:






More information about the wine-patches mailing list