popup menus with zero px height

Christian Kristukat gekauft at hoc.net
Tue Jun 22 10:25:34 CDT 2004


Microcal Origin opens a color chooser popup menus with 0px height. This 
is due to the items having 0 px height. The patch checks that case and 
adds a constant (12) to lpitem->rect.bottom. Using a constant is surely 
quite ugly but helps in that case. I'd really appreciate to see that 
patch accepted as it's the only really annoying thing when using that 
application.

Changelog:
     - check for 0px high MenuItems


Index: menu.c
===================================================================
RCS file: /home/wine/wine/controls/menu.c,v
retrieving revision 1.183
diff -u -r1.183 menu.c
--- menu.c      18 Jun 2004 19:31:57 -0000      1.183
+++ menu.c      22 Jun 2004 15:09:30 -0000
@@ -887,6 +887,9 @@
          else
              lpitem->rect.bottom += mis.itemHeight;

+       if (lpitem->rect.top == lpitem->rect.bottom)
+         lpitem->rect.bottom += 12;
+
         TRACE("id=%04x size=%dx%d\n",
                       lpitem->wID, mis.itemWidth, mis.itemHeight);
          /* Fall through to get check/arrow width calculation. */




More information about the wine-patches mailing list