fix crash in winecfg's x11 dialog due to invalid "Desktop" settings

Mike Hearn mh at codeweavers.com
Mon Mar 29 05:07:03 CST 2004


On Sun, 28 Mar 2004 13:31:15 -0500, Chris Morgan wrote:
> +    if(!bufindex) /* handle invalid "Desktop" values */
> +    {
> +      buf = strdup("640x480");
> +      bufindex = strchr(buf, 'x');
> +    }

It's not a big deal but there's a memory leak there, you need to free buf
before strduping the default (which ideally should be a const str at the
top of the function so if/when we change the default it's only done in one
place).

thanks -mike




More information about the wine-patches mailing list