Fix InternetCrackUrlW

Maxime Bellengé maxime.bellenge at wanadoo.fr
Sun Oct 10 04:43:41 CDT 2004


Thanks for your comments, here is a new version with your comments taken
into account.
I have added a testcase.
However, I don't know what to do when a copy of the path is not
required. For now with the patch, it still points to the url with '\'.

Changelog: 
     * Convert \ to / in urls in InternetCrackUrl.
     * Add a testcase for urls with backslashes.


On Fri, 2004-10-08 at 17:03 -0700, Alexandre Julliard wrote:
> Maxime Bellengé <maxime.bellenge at wanadoo.fr> writes:
> 
> > An application I try to install calls InternetOpenUrlW with an url like
> > that :
> >
> > http://server/.\\path/file
> >
> > Under windows, it works but under wine , the result of such a request is
> > 404.
> > So my assumption is windows converts '\' to '/'. I tried that and now it
> > works perfectly under wine.
> >
> > Changelog: 
> >     * Convert \ to / in urls.
> 
> You cannot do that, because InternetCrackUrl doesn't always make a
> copy of the path, it may return a pointer to the original buffer. The
> conversion may need to be done at some other level, or you may need to
> only do it when copying the path. Either way writing a test case would
> be a good idea.
> 
-- 
Maxime Bellengé <maxime.bellenge at wanadoo.fr>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wininet.patch
Type: text/x-patch
Size: 2944 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20041010/fcf9ec19/wininet.bin


More information about the wine-patches mailing list