Startmenu

[Thorsten Kani]

Nice Patch - looks good now!
i have changed the offsets and used SM_CXBORDER instead of SM_CXEDGE.
(According to MSDN, cxedge is used for 3D while cxborder is used for Flat )
This seems to fix the"draw below" issue. Visual Experience comes now 
really near native.
 
I noticed that SM_CXEDGE is used everywhere, regardless of Style 
TBSTYLE_FLAT.
Please review my attached Patch. It seems to me that this Stylechecks 
shoud be used everywhere.

As for String position issue, maybe i can help out with the controlspy 
check.
Im interested in understanding the controls and wanted to play around 
with CSpy anyway.
Suggestions ?

Tho

Robert Shearman wrote:

> Thanks. Could you try the attached patch which should fix the white 
> background issue?
> Also, could you try setting both OFFSET_X and OFFSET_Y to 0 in 
> wine/dlls/comctl32/toolbar.c
> The strings being in the wrong position is a bigger issue. If you are 
> interested, the problem is that we recalculate and redraw our toolbar 
> control too much so that the code to create the Start Menu expects 
> that it won't be refreshed until it has finished setting the various 
> properties of the toolbar. I have some unfinished work in the toolbar 
> control at the moment, but I plan to use controlspy to see which 
> messages should cause a redraw and which shouldn't.
>
> Rob
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SM_CXBORDER.png
Type: image/png
Size: 6261 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20041020/81fd238b/SM_CXBORDER.png
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SM_CXBORDER.diff
Type: text/x-diff
Size: 1439 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20041020/81fd238b/SM_CXBORDER.bin