MSHTML: Fix comment about hack

Jacek Caban jack at itma.pwr.wroc.pl
Wed Aug 3 15:44:32 CDT 2005


Alexandre, thanks for implementing SetDllDirectory.
Unfortunatelly, in contrast to my comment in patch,
we can't use it for loading Gecko as it could affect
other applications. I've checked that the Gecko dir has
to remain on the path, so we cannot set it at the time
of loading XPCOM and restore it after, in contrast to
what I had previously expected.

Changelog:
    Fix comment about hack
-------------- next part --------------
Index: dlls/mshtml/nsembed.c
===================================================================
RCS file: /home/wine/wine/dlls/mshtml/nsembed.c,v
retrieving revision 1.1
diff -u -p -r1.1 nsembed.c
--- dlls/mshtml/nsembed.c	1 Aug 2005 10:59:45 -0000	1.1
+++ dlls/mshtml/nsembed.c	3 Aug 2005 20:31:06 -0000
@@ -152,10 +152,7 @@ static BOOL load_gecko()
 
     hXPCOM = LoadLibraryW(strXPCOM);
     if(!hXPCOM) {
-        /* FIXME:
-         * We don't have any SetDllDirectory implementation so we have to modify PATH,
-         * as XPCOM loads other DLLs from this directory.
-         */
+        /* We have to modify PATH as XPCOM loads other DLLs from this directory. */
         WCHAR path_env[MAX_PATH];
         static WCHAR wszPATH[] = {'P','A','T','H',0};
         int len;


More information about the wine-patches mailing list