MSI: store the component information in a standard Wine list

Mike McCormack mike at codeweavers.com
Fri Aug 19 01:11:02 CDT 2005


Lionel Ulmer wrote:
> The MSI installer downloadable for free at the following URL
> ( http://www.telltalegames.com/products?pc=tth01 ) crashes with Wine.
> 
> After discussing it with Mike (M) on IRC, he found out that the installer
> uses more that the hard-coded limit of 1024 components and thus overflows
> the array which leads to a crash later on.
> 
> He provided the hacky patch attached to this mail (it lets the game install)
> but, in his own words, the best way to fix this would be to remove the
> fixed size arrays and replace it with any 'unlimited' data structure (linked
> lists, ...).

This is a more correct fix for the problem found by Lionel.  This fixes 
a buffer overrun in installation of "Telltale Texas HoldEm! 
Installer.msi" from the above link, which was caused by an unchecked 
hard limit of 1024 on the number of components that a feature could have.

Mike


Changelog:
* store the component information in a standard Wine list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: msi-component-list.diff
Type: text/x-patch
Size: 12325 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20050819/1e2847dc/msi-component-list.bin


More information about the wine-patches mailing list