Patch for HTTP_HttpSendRequestW with NULL verb

David McCullough davidm at snapgear.com
Wed Feb 2 00:50:19 CST 2005


Hi all,

I have been trying to get the AGFAnet print client running under wine,
but it kept complaining that the internet connection was down.

After digging through the code and adding trace I found that
HTTP_HttpSendRequestW was getting invoked with the verb field set to
NULL.  All the doc I could find says that this means the GET method
should be used.  Having changed it to just use GET under this
scenario I can now get the app mostly up and running.

I have yet to actually pay for photo processing using it under wine
though ;-)  Maybe tonight I'll get some photo's printed.

The AGFAnet SW can be found at:

	http://www.agfanet.com/en/ips/cont_download.php3

I am currently using version 3.0.  Should I be adding the app to a list
somewhere ?

Cheers,
Davidm



Changelog
	David McCullough <davidm at snapgear.com>
	HTTP_HttpSendRequestW was getting invoked with a null verb,
	the doc I could find says this should default to the GET method.

Patch (against todays CVS)

Index: dlls/wininet/http.c
===================================================================
RCS file: /home/wine/wine/dlls/wininet/http.c,v
retrieving revision 1.94
diff -u -p -r1.94 http.c
--- dlls/wininet/http.c	1 Feb 2005 18:50:54 -0000	1.94
+++ dlls/wininet/http.c	2 Feb 2005 06:40:16 -0000
@@ -1506,10 +1506,11 @@ BOOL WINAPI HTTP_HttpSendRequestW(LPWINI
     INTERNET_SetLastError(0);
 
 
-    /* We must have a verb */
+    /* if the verb is NULL default to GET */
     if (NULL == lpwhr->lpszVerb)
     {
-	    goto lend;
+	static const WCHAR szGET[] = { 'G','E','T', 0 };
+	lpwhr->lpszVerb = WININET_strdupW(szGET);
     }
 
     /* if we are using optional stuff, we must add the fixed header of that option length */

-- 
David McCullough, davidm at snapgear.com  Ph:+61 7 34352815 http://www.SnapGear.com
Custom Embedded Solutions + Security   Fx:+61 7 38913630 http://www.uCdot.org



More information about the wine-patches mailing list