MSI: fix a memory leak in MsiConfigureProductExW

Mike McCormack mike at codeweavers.com
Tue Feb 8 08:25:30 CST 2005


ChangeLog:
* fix a memory leak in MsiConfigureProductExW
-------------- next part --------------
Index: dlls/msi/msi.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/msi.c,v
retrieving revision 1.57
diff -u -p -r1.57 msi.c
--- dlls/msi/msi.c	8 Feb 2005 12:12:29 -0000	1.57
+++ dlls/msi/msi.c	8 Feb 2005 14:26:08 -0000
@@ -476,7 +476,7 @@ UINT WINAPI MsiConfigureProductExW(LPCWS
      * ok 1, we need to find the msi file for this product.
      *    2, find the source dir for the files
      *    3, do the configure/install.
-          4, cleanupany runonce entry. 
+     *    4, cleanupany runonce entry. 
      */
 
     rc = MsiOpenProductW(szProduct,&handle);
@@ -485,7 +485,7 @@ UINT WINAPI MsiConfigureProductExW(LPCWS
 
     package = msihandle2msiinfo(handle, MSIHANDLETYPE_PACKAGE);
   
-     sz = strlenW(szInstalled);
+    sz = strlenW(szInstalled);
 
     if (szCommandLine)
         sz += strlenW(szCommandLine);
@@ -501,6 +501,8 @@ UINT WINAPI MsiConfigureProductExW(LPCWS
         strcatW(commandline,szInstalled);
 
     rc = ACTION_DoTopLevelINSTALL(package, sourcepath, commandline);
+
+    msiobj_release( &package->hdr );
 
     HeapFree(GetProcessHeap(),0,commandline);
 end:


More information about the wine-patches mailing list