MSI: fix up the summary information code a little
Mike McCormack
mike at codeweavers.com
Tue Feb 15 21:02:53 CST 2005
ChangeLog:
* fix up the summary information code a little
-------------- next part --------------
Index: dlls/msi/suminfo.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/suminfo.c,v
retrieving revision 1.12
diff -u -p -r1.12 suminfo.c
--- dlls/msi/suminfo.c 1 Feb 2005 14:21:03 -0000 1.12
+++ dlls/msi/suminfo.c 16 Feb 2005 03:04:03 -0000
@@ -108,11 +108,9 @@ UINT WINAPI MsiGetSummaryInformationW(MS
if( FAILED( r ) )
{
ERR("IStorage -> IPropertySetStorage failed\n");
- if (db)
- msiobj_release(&db->hdr);
- return ERROR_FUNCTION_FAILED;
+ ret = ERROR_FUNCTION_FAILED;
+ goto end;
}
- ERR("storage = %p propertysetstorage = %p\n", db->storage, psstg);
grfMode = STGM_READ | STGM_SHARE_EXCLUSIVE;
r = IPropertySetStorage_Open( psstg, &FMTID_SummaryInformation, grfMode, &ps );
@@ -135,7 +133,7 @@ UINT WINAPI MsiGetSummaryInformationW(MS
suminfo->propstg = ps;
handle = alloc_msihandle( &suminfo->hdr );
if( handle )
- *phSummaryInfo = handle;
+ *phSummaryInfo = handle;
else
ret = ERROR_FUNCTION_FAILED;
msiobj_release( &suminfo->hdr );
@@ -145,7 +143,7 @@ end:
IPropertyStorage_Release(ps);
if( psstg )
IPropertySetStorage_Release(psstg);
- if (db)
+ if( db )
msiobj_release(&db->hdr);
return ret;
@@ -275,19 +273,24 @@ UINT WINAPI MsiSummaryInfoGetPropertyW(
UINT WINAPI MsiSummaryInfoSetPropertyA( MSIHANDLE hSummaryInfo, UINT uiProperty,
UINT uiDataType, INT iValue,
- FILETIME* pftValue, LPSTR szValue)
+ FILETIME* pftValue, LPSTR szValue )
{
+ FIXME("%ld %u %u %i %p %s\n", hSummaryInfo, uiProperty,
+ uiDataType, iValue, pftValue, debugstr_a(szValue) );
return ERROR_CALL_NOT_IMPLEMENTED;
}
UINT WINAPI MsiSummaryInfoSetPropertyW( MSIHANDLE hSummaryInfo, UINT uiProperty,
UINT uiDataType, INT iValue,
- FILETIME* pftValue, LPWSTR szValue)
+ FILETIME* pftValue, LPWSTR szValue )
{
+ FIXME("%ld %u %u %i %p %s\n", hSummaryInfo, uiProperty,
+ uiDataType, iValue, pftValue, debugstr_w(szValue) );
return ERROR_CALL_NOT_IMPLEMENTED;
}
-UINT WINAPI MsiSummaryInfoPersist(MSIHANDLE hSummaryInfo)
+UINT WINAPI MsiSummaryInfoPersist( MSIHANDLE hSummaryInfo )
{
+ FIXME("%ld\n", hSummaryInfo );
return ERROR_CALL_NOT_IMPLEMENTED;
}
More information about the wine-patches
mailing list