MSI: action.c

Ulrich Czekalla ulrich.czekalla at utoronto.ca
Wed Feb 23 18:15:19 CST 2005


ChangeLog:
    Ulrich Czekalla <ulrich at codeweavers.com>
    Prevent accessing freed memory in failure case
-------------- next part --------------
Index: dlls/msi/action.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/action.c,v
retrieving revision 1.91
diff -u -p -r1.91 action.c
--- dlls/msi/action.c	22 Feb 2005 19:31:45 -0000	1.91
+++ dlls/msi/action.c	24 Feb 2005 00:11:18 -0000
@@ -3206,7 +3206,6 @@ static UINT ACTION_DuplicateFiles(MSIPAC
         }
 
         dest = build_directory_name(2, dest_path, dest_name);
-        HeapFree(GetProcessHeap(), 0, dest_path);
            
         TRACE("Duplicating file %s to %s\n",debugstr_w(file_source),
               debugstr_w(dest)); 
@@ -3222,6 +3221,7 @@ static UINT ACTION_DuplicateFiles(MSIPAC
         FIXME("We should track these duplicate files as well\n");   
  
         msiobj_release(&row->hdr);
+        HeapFree(GetProcessHeap(),0,dest_path);
         HeapFree(GetProcessHeap(),0,dest);
         HeapFree(GetProcessHeap(),0,file_source);
     }


More information about the wine-patches mailing list