[shell32] Load file context menu from resources [Resent]

Tobias Burnus burnus at net-b.de
Sun Jun 19 06:35:49 CDT 2005

Second try (unchanged). Any suggestions how to improve the patch are 


Changed file overview:
- shv_item_cmenu.c: Load from resources (the [currently unused] MENU 
resource already exists)
- shell32_?.rc: Comment out two items (and a separator) and
copy text from IDS_SELECT, needed to match the current context menu
("Select" present, "Properties" and "Create Link" are not)

  shell32_Cs.rc    |    7 ++---
  shell32_De.rc    |   14 +++++-----
  shell32_En.rc    |    7 ++---
  shell32_Es.rc    |    7 ++---
  shell32_Fr.rc    |    7 ++---
  shell32_It.rc    |    9 +++---
  shell32_Ja.rc    |    6 ++--
  shell32_Pl.rc    |    7 ++---
  shell32_Pt.rc    |    7 ++---
  shell32_Uk.rc    |    1
  shv_item_cmenu.c |   75 
  11 files changed, 84 insertions(+), 63 deletions(-)



this is patch converts ISvItemCm_fnQueryContextMenu of
shell32/shv_item_cmenu.c to use the already existing
MENU_SHV_FILE resource. I used the items of ISvItemCm_fnQueryContextMenu
which means I commented out
the "Properties" and the "Create Link" menu item and added an "Select"
item (I could copy the string from IDS_SELECT).
The Japanese menu will not completely work since some menu items are
If I understand the current implementation correct, one sometimes gets
"Open" and "Select" menu items which both have the same ID; I don't know
whether this is correct, but this is the current implementation. (Since
they use the same ID, I cannot use MF_BYCOMMAND in swapping Open/Explore
and in conditionally removing Select, which makes the Japanese menu even
more wrong.)

Review note: Some of the logic (LoadMenu, Merging menus) is taken from
shv_bg_cmenu.c's ISVBgCm_fnQueryContextMenu.

      Tobias Burnus <burnus at net-b.de>
      Use resource files for open file dialogs' file context menu


-------------- next part --------------
A non-text attachment was scrubbed...
Name: shell32-patch.diff
Type: text/x-patch
Size: 14252 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20050619/9bd55f71/shell32-patch.bin

More information about the wine-patches mailing list