MSHTML: THIS macros clean up

Jacek Caban jack at
Tue Jun 28 17:49:50 CDT 2005

Dimi Paun wrote:

>This code looks weird. It should still look like C code,
>even if we use a macro. I would suggest something like this:
>static HRESULT WINAPI PersistMoniker_Load(IPersistMoniker *iface, BOOL
>        IMoniker *pimkName, LPBC pibc, DWORD grfMode)
>    HTMLDocument *This = PERSISTMON_THIS(iface);
>    FIXME("(%p)->(%x %p %p %08lx)\n", This, fFullyAvailable, pimkName, pibc,
>    return S_OK;
>It's a bit more verbose, but a lot more readable.
Ok, it really looks better. Problem is that macros like
PERSISTMON_THIS are in whole mshtml so I'll have to
clean up much more. I'll do so later.
Alexandre: please don't apply this patch.


More information about the wine-patches mailing list