[user] edit: Fix tests clearly failing on all platforms

Vitaliy Margolen wine-patch at kievinfo.com
Thu Jun 30 12:09:35 CDT 2005


Looking at winerash results noticed few tests that were failing on all native
versions 

Vitaliy Margolen

changelog:
  dlls/user/test/edit.c
    Fix tests failing an all native versions
  dlls/user/edit.c
    Fix some failing tests
-------------- next part --------------
Index: dlls/user/edit.c
===================================================================
RCS file: /home/wine/wine/dlls/user/edit.c,v
retrieving revision 1.34
diff -u -p -r1.34 edit.c
--- dlls/user/edit.c	27 Jun 2005 09:42:40 -0000	1.34
+++ dlls/user/edit.c	30 Jun 2005 17:00:24 -0000
@@ -1457,7 +1457,7 @@ static INT EDIT_CharFromPos(EDITSTATE *e
                             x_low = x_now;
                         }
                     }
-                    if (abs(x_high - x) <= abs(x_low - x) + 1)
+                    if (abs(x_high - x) + 1 <= abs(x_low - x))
                         index = high;
                     else
                         index = low;
Index: dlls/user/tests/edit.c
===================================================================
RCS file: /home/wine/wine/dlls/user/tests/edit.c,v
retrieving revision 1.10
diff -u -p -r1.10 edit.c
--- dlls/user/tests/edit.c	25 Jun 2005 18:32:07 -0000	1.10
+++ dlls/user/tests/edit.c	30 Jun 2005 17:02:02 -0000
@@ -865,7 +865,7 @@ static void test_edit_control_4(void)
     SendMessage(hwEdit, WM_SETTEXT, 0, (LPARAM) "aa");
     lo = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 0, 0));
     hi = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 1, 0));
-    mid = lo + (hi - lo) / 2;
+    mid = lo + (hi - lo) / 2 +1;
 
     for (i = lo; i < mid; i++) {
        ret = LOWORD(SendMessage(hwEdit, EM_CHARFROMPOS, 0, (LPARAM) i));
@@ -883,7 +883,7 @@ static void test_edit_control_4(void)
     SendMessage(hwEdit, WM_SETTEXT, 0, (LPARAM) "aa");
     lo = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 0, 0));
     hi = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 1, 0));
-    mid = lo + (hi - lo) / 2;
+    mid = lo + (hi - lo) / 2 +1;
 
     for (i = lo; i < mid; i++) {
        ret = LOWORD(SendMessage(hwEdit, EM_CHARFROMPOS, 0, (LPARAM) i));
@@ -901,7 +901,7 @@ static void test_edit_control_4(void)
     SendMessage(hwEdit, WM_SETTEXT, 0, (LPARAM) "aa");
     lo = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 0, 0));
     hi = LOWORD(SendMessage(hwEdit, EM_POSFROMCHAR, 1, 0));
-    mid = lo + (hi - lo) / 2;
+    mid = lo + (hi - lo) / 2 +1;
 
     for (i = lo; i < mid; i++) {
        ret = LOWORD(SendMessage(hwEdit, EM_CHARFROMPOS, 0, (LPARAM) i));


More information about the wine-patches mailing list