[QCAP] Capturegraph fixes2

Maarten Lankhorst m.b.lankhorst at gmail.com
Wed May 18 09:17:39 CDT 2005


Fixed CaptureGraphBuilder SetFiltergraph failure.
Added debug info
Added Objrefcount info for dllcanunloadnow

AGAIN forgot to attach patch, grr @ me
-------------- next part --------------
Index: capturegraph.c
===================================================================
RCS file: /home/wine/wine/dlls/qcap/capturegraph.c,v
retrieving revision 1.1
diff -u -p -r1.1 capturegraph.c
--- capturegraph.c	7 May 2005 18:18:39 -0000	1.1
+++ capturegraph.c	18 May 2005 14:11:50 -0000
@@ -47,9 +47,7 @@
 #include "wine/unicode.h"
 #include "wine/debug.h"
 
-WINE_DEFAULT_DEBUG_CHANNEL(quartz);
-
-static const WCHAR wcsInputPinName[] = {'i','n','p','u','t',' ','p','i','n',0};
+WINE_DEFAULT_DEBUG_CHANNEL(qcap);
 
 /***********************************************************************
 *   ICaptureGraphBuilder & ICaptureGraphBuilder2 implementation
@@ -104,6 +102,7 @@ IUnknown * CALLBACK QCAP_createCaptureGr
         pCapture->mygraph = NULL;
         InitializeCriticalSection(&pCapture->csFilter);
         *phr = S_OK;
+        ObjectRefCount(TRUE);
     }
     return (IUnknown *)pCapture;
 }
@@ -163,10 +162,9 @@ fnCaptureGraphBuilder2_Release(ICaptureG
         if (This->mygraph != NULL)
             IGraphBuilder_Release((IGraphBuilder *)This->mygraph);
         CoTaskMemFree(This);
-        return 0;
+        ObjectRefCount(FALSE);
     }
-    else
-        return ref;
+    return ref;
 }
 
 static HRESULT WINAPI
@@ -181,7 +179,7 @@ fnCaptureGraphBuilder2_SetFilterGraph(IC
 
     TRACE("(%p/%p)->(%p)\n", This, iface, pfg);
 
-    if (!This->mygraph)
+    if (This->mygraph)
         return E_UNEXPECTED;
 
     if (!pfg)
@@ -364,7 +362,7 @@ fnCaptureGraphBuilder_QueryInterface(ICa
                                      REFIID riid, LPVOID * ppv)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return IUnknown_QueryInterface(_ICaptureGraphBuilder2_(This), riid, ppv);
 }
 
@@ -372,7 +370,7 @@ static ULONG WINAPI
 fnCaptureGraphBuilder_AddRef(ICaptureGraphBuilder * iface)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return IUnknown_AddRef(_ICaptureGraphBuilder2_(This));
 }
 
@@ -380,7 +378,7 @@ static ULONG WINAPI
 fnCaptureGraphBuilder_Release(ICaptureGraphBuilder * iface)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return IUnknown_Release(_ICaptureGraphBuilder2_(This));
 }
 
@@ -389,7 +387,7 @@ fnCaptureGraphBuilder_SetFiltergraph(ICa
                                      IGraphBuilder *pfg)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_SetFiltergraph(_ICaptureGraphBuilder2_(This), pfg);
 }
 
@@ -398,7 +396,7 @@ fnCaptureGraphBuilder_GetFiltergraph(ICa
                                      IGraphBuilder **pfg)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_GetFiltergraph(_ICaptureGraphBuilder2_(This), pfg);
 }
 
@@ -408,7 +406,7 @@ fnCaptureGraphBuilder_SetOutputFileName(
                                         IBaseFilter **ppf, IFileSinkFilter **ppSink)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_SetOutputFileName(_ICaptureGraphBuilder2_(This),
                                                    pType, lpstrFile, ppf, ppSink);
 }
@@ -419,7 +417,7 @@ fnCaptureGraphBuilder_FindInterface(ICap
                                     REFIID riid, void **ppint)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_FindInterface(_ICaptureGraphBuilder2_(This),
                                                pCategory, NULL, pf, riid, ppint);
 }
@@ -430,7 +428,7 @@ fnCaptureGraphBuilder_RenderStream(ICapt
                                    IBaseFilter *pfCompressor, IBaseFilter *pfRenderer)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_RenderStream(_ICaptureGraphBuilder2_(This),
                                               pCategory, NULL, pSource,
                                               pfCompressor, pfRenderer);
@@ -443,7 +441,7 @@ fnCaptureGraphBuilder_ControlStream(ICap
                                     WORD wStartCookie, WORD wStopCookie)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_ControlStream(_ICaptureGraphBuilder2_(This),
                                                pCategory, NULL, pFilter, pstart, 
                                                pstop, wStartCookie, wStopCookie);
@@ -454,7 +452,7 @@ fnCaptureGraphBuilder_AllocCapFile(ICapt
                                    LPCOLESTR lpstr, DWORDLONG dwlSize)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_AllocCapFile(_ICaptureGraphBuilder2_(This),
                                               lpstr, dwlSize);
 }
@@ -466,7 +464,7 @@ fnCaptureGraphBuilder_CopyCaptureFile(IC
                                       IAMCopyCaptureFileProgress *pCallback)
 {
     _ICOM_THIS_From_ICaptureGraphBuilder(CaptureGraphImpl, iface);
-
+    TRACE("%p --> Forwarding to v2 (%p)\n", iface, This);
     return ICaptureGraphBuilder2_CopyCaptureFile(_ICaptureGraphBuilder2_(This),
                                                  lpwstrOld, lpwstrNew,
                                                  fAllowEscAbort, pCallback);


More information about the wine-patches mailing list