WININET: small fix for InternetCreateUrlA

Saulius Krasuckas saulius2 at ar.fi.lt
Fri Nov 4 11:22:57 CST 2005


This was a one minute looker, so it can contain some logical errors or so.


Log message:
	Saulius Krasuckas <saulius.krasuckas at ieee.org>
	- Fix a test for InternetCreateUrlA as no Windows platform sets 
	last error here.
	- Make InternetCreateUrlA pass the test.


Index: dlls/wininet/tests/http.c
===================================================================
RCS file: /home/wine/wine/dlls/wininet/tests/http.c,v
retrieving revision 1.29
diff -p -u -r1.29 http.c
--- dlls/wininet/tests/http.c	31 Oct 2005 14:06:35 -0000	1.29
+++ dlls/wininet/tests/http.c	4 Nov 2005 16:20:34 -0000
@@ -784,8 +784,8 @@ static void InternetCreateUrlA_test()
 	len = 42;
 	ret = InternetCreateUrlA(&urlComp, 0, szUrl, &len);
 	ok(ret, "Expected success\n");
-	ok(GetLastError() == ERROR_ALREADY_EXISTS,
-		"Expected ERROR_ALREADYEXISTS, got %ld\n", GetLastError());
+	ok(GetLastError() == 0xdeadbeef,
+		"Expected 0xdeadbeef, got %ld\n", GetLastError());
 	ok(len == 32, "Expected len 32, got %ld\n", len);
 	ok(!strcmp(szUrl, CREATE_URL4), "Expected %s, got %s\n", CREATE_URL3, szUrl);
 
Index: dlls/wininet/internet.c
===================================================================
RCS file: /home/wine/wine/dlls/wininet/internet.c,v
retrieving revision 1.136
diff -p -u -r1.136 internet.c
--- dlls/wininet/internet.c	31 Oct 2005 14:06:36 -0000	1.136
+++ dlls/wininet/internet.c	4 Nov 2005 16:20:41 -0000
@@ -3467,8 +3467,6 @@ static BOOL calc_url_length(LPURL_COMPON
             SetLastError(ERROR_INVALID_PARAMETER);
             return FALSE;
         }
-        else
-            SetLastError(ERROR_ALREADY_EXISTS);
     }
 
     if (lpUrlComponents->lpszPassword)



More information about the wine-patches mailing list