[d3d9] allow NULL ppQuery to be passed to CreateQuery - 2
Oliver Stieber
oliver_stieber at yahoo.co.uk
Mon Nov 7 16:13:59 CST 2005
This time don't create an object of ppQuery is NULL, I've also made the formatting match the rest
of the file since most of the function changed.
--- Alexandre Julliard <julliard at winehq.org> wrote:
> Oliver Stieber <oliver_stieber at yahoo.co.uk> writes:
>
> > @@ -142,9 +142,10 @@
> > FIXME("(%p) call to IWineD3DDevice_CreateQuery failed\n", This);
> > HeapFree(GetProcessHeap(), 0, object);
> > *ppQuery = NULL;
> > - } else {
> > + } else if (ppQuery != NULL) {
> > *ppQuery = (LPDIRECT3DQUERY9) object;
> > }
>
> That doesn't look right. Who's going to free the object if you don't
> return it?
>
> --
> Alexandre Julliard
> julliard at winehq.org
>
>
>
___________________________________________________________
Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: d3d9-query-allow-null-ppquery-os-2.patch
Type: text/x-diff
Size: 2463 bytes
Desc: 819331341-d3d9-query-allow-null-ppquery-os-2.patch
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20051107/b7432595/d3d9-query-allow-null-ppquery-os-2.patch
More information about the wine-patches
mailing list