PATCH: CreateProcessW possible buffer overflow

Marcus Meissner meissner at suse.de
Sun Oct 9 14:48:38 CDT 2005


Hi,

get_file_name gets characters, not bytes.

Ciao, Marcus

Changelog:
	pass characters to get_file_name() helper, not bytes.

Index: dlls/kernel/process.c
===================================================================
RCS file: /home/wine/wine/dlls/kernel/process.c,v
retrieving revision 1.108
diff -u -r1.108 process.c
--- dlls/kernel/process.c	4 Oct 2005 18:09:51 -0000	1.108
+++ dlls/kernel/process.c	9 Oct 2005 19:46:40 -0000
@@ -1837,7 +1837,7 @@
 
     TRACE("app %s cmdline %s\n", debugstr_w(app_name), debugstr_w(cmd_line) );
 
-    if (!(tidy_cmdline = get_file_name( app_name, cmd_line, name, sizeof(name), &hFile )))
+    if (!(tidy_cmdline = get_file_name( app_name, cmd_line, name, sizeof(name)/sizeof(WCHAR), &hFile )))
         return FALSE;
     if (hFile == INVALID_HANDLE_VALUE) goto done;
 



More information about the wine-patches mailing list