[AppDB] Clean up View Distributions, add back link to the application version and use the right time function.

Tony Lambregts tony.lambregts at gmail.com
Mon Oct 17 20:53:51 CDT 2005


I used the wrong time function to display the date the test was entered. Doh!

So while I was at it I cleaned up the page to view a distribution a bit and 
added a link to view the testing results in the version screen.

Change Log: Clean up View Distributions, add back link to the application 
version and use the right time function.

Files Changed: distributionView.php include/testResults.php
-------------- next part --------------
Index: distributionView.php
===================================================================
RCS file: /home/wine/appdb/distributionView.php,v
retrieving revision 1.1
diff -u -r1.1 distributionView.php
--- distributionView.php	17 Oct 2005 03:59:24 -0000	1.1
+++ distributionView.php	18 Oct 2005 01:41:49 -0000
@@ -33,18 +33,21 @@
     echo $oDistribution->sName;
 
     if ($oDistribution->sUrl) 
+    {
         echo " (".$oDistribution->sUrl.")";
         echo "</a> <br />\n";
-
-    echo "<br />\n";
+    }
+    else 
+        echo "<br />\n";
 
     if($oDistribution->aTestingIds)
     {
-        echo "<br />Testing results for ".$oDistribution->sName."<br /><ol>\n";
-        echo '<p><span class="title">Testing Results</span><br />',"\n";
+//        echo "<br />Testing results for ".$oDistribution->sName."<br /><ol>\n";
+        echo '<p><span class="title">Testing Results for '.$oDistribution->sName.'</span><br />',"\n";
         echo '<table width="100%" border="1">',"\n";
         echo '<thead class="historyHeader">',"\n";
         echo '<tr>',"\n";
+        echo '<td>Application Version</td>',"\n";
         echo '<td>Submitter</td>',"\n";
         echo '<td>Date Submitted</td>',"\n";
         echo '<td>Wine version</td>',"\n";
@@ -60,16 +63,18 @@
             $oSubmitter = new User($oTest->iSubmitterId);
             $bgcolor = $oTest->sTestedRating;
             echo '<tr class='.$bgcolor.'>',"\n";
-            echo '    <td>',"\n";
+            echo '<td><a href="'.BASE.'appview.php?versionId='.$oTest->iVersionId.'&iTestingId='.$oTest->iTestingId.'">',"\n";
+            echo $oApp->sName.' '.$oVersion->sName.'</a></td>',"\n";
+            echo '<td>',"\n";
             echo $oSubmitter->sEmail ? "<a href=\"mailto:".$oSubmitter->sEmail."\">":"";
             echo $oSubmitter->sRealname;
             echo $oSubmitter->sEmail ? "</a>":"";
-            echo '    </td>',"\n";
-            echo '    <td>'.date("M d Y", mysqldatetime_to_unixtimestamp($oTest->sSubmitTime)).'</td>',"\n";
-            echo '    <td>'.$oTest->sTestedRelease.'&nbsp</td>',"\n";
-            echo '    <td>'.$oTest->sInstalls.'&nbsp</td>',"\n";
-            echo '    <td>'.$oTest->sRuns.'&nbsp</td>',"\n";
-            echo '    <td>'.$oTest->sTestedRating.'&nbsp</td>',"\n";
+            echo '</td>',"\n";
+            echo '<td>'.date("M d Y", mysqltimestamp_to_unixtimestamp($oTest->sSubmitTime)).'</td>',"\n";
+            echo '<td>'.$oTest->sTestedRelease.'&nbsp</td>',"\n";
+            echo '<td>'.$oTest->sInstalls.'&nbsp</td>',"\n";
+            echo '<td>'.$oTest->sRuns.'&nbsp</td>',"\n";
+            echo '<td>'.$oTest->sTestedRating.'&nbsp</td>',"\n";
             echo '</tr>',"\n";
         }
         echo '</table>',"\n";
Index: include/testResults.php
===================================================================
RCS file: /home/wine/appdb/include/testResults.php,v
retrieving revision 1.1
diff -u -r1.1 testResults.php
--- include/testResults.php	17 Oct 2005 03:59:24 -0000	1.1
+++ include/testResults.php	18 Oct 2005 01:41:57 -0000
@@ -379,7 +379,7 @@
             echo '<a href="'.BASE.'distributionView.php?iDistributionId='.$oTest->iDistributionId.'">',"\n";
             echo $oDistribution->sName.'</a>',"\n";
             echo '    </td>',"\n";
-            echo '    <td>'.date("M d Y", mysqldatetime_to_unixtimestamp($oTest->sSubmitTime)).'</td>',"\n";
+            echo '    <td>'.date("M d Y", mysqltimestamp_to_unixtimestamp($oTest->sSubmitTime)).'</td>',"\n";
             echo '    <td>'.$oTest->sTestedRelease.'&nbsp</td>',"\n";
             echo '    <td>'.$oTest->sInstalls.'&nbsp</td>',"\n";
             echo '    <td>'.$oTest->sRuns.'&nbsp</td>',"\n";


More information about the wine-patches mailing list