OleFont: Fix IDispatch Implementation (was Re: olefont: GetIDsOfNames)

Walt Ogburn reuben at ugcs.caltech.edu
Wed Sep 14 15:33:10 CDT 2005

On Wed, 14 Sep 2005, Robert Shearman wrote:
> You're not being lazy enough. All of this stuff can be easily
> implemented in one go using CreateStdDispatch, as long as you know how
> to use it. Try the attached patch.
> Changelog:
> Return the standard font IDispatch interface created using
> CreateStdDispatch on top of a typelib instead of manually implementing
> the necessary methods.

That doesn't look very lazy to me, but it simplifies olefont very nicely
(300 fewer lines!).  Please use this patch for GetIDsOfNames instead of

My patch for DispGetIDsOfNames and the test for IFontDisp_GetIDsOfNames
are still OK.  With Robert Shearman's big patch to olefont.c and my small
one to typelib.c, the tests in my patch to tests/olefont.c all pass.


More information about the wine-patches mailing list