winecfg: appdefaults: Fix issues with LVM_GETITEMW by removing superfluous flag

Frank Richter frank.richter at gmail.com
Wed Aug 16 13:46:13 CDT 2006


The LVIF_TEXT flag is not only unneeded there, but as the 'item'
structure is not completely initialized also causes issues since the
list view will attempt to access bogus memory addresses. Mostly found
and solved by Paul Vriens.

-------------- next part --------------
>From 0bc3a629d6cbabd86e54ff39655650c32cfe7787 Mon Sep 17 00:00:00 2001
From: Frank Richter frank.richter at gmail.com <frank.richter at gmail.com>
Date: Wed, 16 Aug 2006 20:43:51 +0200
Subject: [PATCH] winecfg: appdefaults: Fix issues with LVM_GETITEMW by removing superfluous flag
---
 programs/winecfg/appdefaults.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c
index bca7f7a..ad6b7cc 100644
--- a/programs/winecfg/appdefaults.c
+++ b/programs/winecfg/appdefaults.c
@@ -314,7 +314,7 @@ static void on_remove_app_click(HWND dia
     LVITEMW item;
 
     item.iItem = selection;
-    item.mask = LVIF_PARAM | LVIF_TEXT;
+    item.mask = LVIF_PARAM;
 
     WINE_TRACE("selection=%d, section=%s\n", selection, section);
     
-- 
1.4.1.1



More information about the wine-patches mailing list