[AppDB] modify installs and runs fields

Tony Lambregts tony.lambregts at gmail.com
Sun Feb 5 15:33:00 CST 2006


Following a conversation on irc I came up with the following patch

You need to run the folloeing sql for this patch to work

Alter table testResults modify runs enum('Yes','No','N/A') NOT NULL;
Alter table testResults modify installs enum('Yes','No','Not Installable') NOT NULL;
UPDATE testResults SET runs = "Not Installable" where runs = "";


Change log: modify installs and runs fields

Files changed: include/testResults.php tables/testResults.sql

-------------- next part --------------
Index: include/testResults.php
===================================================================
RCS file: /home/wine/appdb/include/testResults.php,v
retrieving revision 1.7
diff -u -u -r1.7 testResults.php
--- include/testResults.php	17 Jan 2006 02:34:58 -0000	1.7
+++ include/testResults.php	5 Feb 2006 21:32:15 -0000
@@ -617,15 +617,15 @@
     
     echo "<select name='$varname'>\n";
     echo "<option value=\"\">Choose ...</option>\n";
-    $aRating = array("Yes", "No");
+    $aRating = array("Yes", "No", "N/A");
     $iMax = count($aRating);
 
     for($i=0; $i < $iMax; $i++)
     {
         if($aRating[$i] == $cvalue)
-            echo "<option value=$aRating[$i] selected>$aRating[$i]\n";
+            echo "<option value='".$aRating[$i]."' selected>".$aRating[$i]."\n";
         else
-            echo "<option value=$aRating[$i]>$aRating[$i]\n";
+            echo "<option value='".$aRating[$i]."'>".$aRating[$i]."\n";
     }
     echo "</select>\n";
 }
@@ -635,15 +635,15 @@
     
     echo "<select name='$varname'>\n";
     echo "<option value=\"\">Choose ...</option>\n";
-    $aRating = array("Yes", "No", "???");
+    $aRating = array("Yes", "No", "Not Installable");
     $iMax = count($aRating);
 
     for($i=0; $i < $iMax; $i++)
     {
         if($aRating[$i] == $cvalue)
-            echo "<option value=$aRating[$i] selected>$aRating[$i]\n";
+            echo "<option value='".$aRating[$i]."' selected>".$aRating[$i]."\n";
         else
-            echo "<option value=$aRating[$i]>$aRating[$i]\n";
+            echo "<option value='".$aRating[$i]."'>".$aRating[$i]."\n";
     }
     echo "</select>\n";
 }
Index: tables/testResults.sql
===================================================================
RCS file: /home/wine/appdb/tables/testResults.sql,v
retrieving revision 1.1
diff -u -u -r1.1 testResults.sql
--- tables/testResults.sql	17 Oct 2005 03:59:24 -0000	1.1
+++ tables/testResults.sql	5 Feb 2006 21:32:15 -0000
@@ -1,7 +1,6 @@
 use apidb;
 
 drop table if exists testResults;
-drop table if exists TestResults;
 
 /*
  * Version Testing results
@@ -15,8 +14,8 @@
         testedDate      datetime not null,
         distributionId  int not null,
 	testedRelease 	tinytext,
-	installs	enum('Yes','No') NOT NULL default 'Yes',
-	runs		enum('Yes','No','???') NOT NULL default 'Yes',
+	installs	enum('Yes','No','N/A') NOT NULL default 'Yes',
+	runs		enum('Yes','No','Not Installable') NOT NULL default 'Yes',
 	testedRating  	tinytext,
         comments        text,
 	submitTime	timestamp(14) NOT NULL,


More information about the wine-patches mailing list