iDisplay Limit User Variable

[Chris Morgan]

Well no comments from killertux but Tony said he would like the see the 
feature so if you could clean this patch up and resubmit we can work on 
getting it into cvs.

Chris



On Friday 10 February 2006 10:28 am, Chris Morgan wrote:
> I'd like to hear what Tony or killertux has to say about it since they
> are pretty heavily involved with developing and using the appdb.
>
> Chris
>
> On 2/9/06, Jason Weisberger <jbdubbs at gmail.com> wrote:
> > Chris,
> >
> > >>I'm wondering if this is adding too much complexity to the display of
> > >> the
> >
> > test
> > results.  Will many users really care to see more than say 5 of the
> > testing results?  Does it help them to show them varying numbers of
> > entries?
> >
> >
> > I guess that's a matter of opinion for each user.  I was looking through
> > the page with variables of screen size, and I found that 5 results looks
> > too limiting on 1280x1024, but lowering to 1024x768 or 800x600, it's just
> > right. Allowing the user to choose how many to show based on system setup
> > and preference might work.
> >
> > I guess before I fix the coding, I take it that you don't think this is a
> > good idea?
> >
> > On 2/10/06, Chris Morgan < cmorgan at alum.wpi.edu> wrote:
> > > I'm wondering if this is adding too much complexity to the display of
> > > the
> >
> > test
> >
> > > results.  Will many users really care to see more than say 5 of the
> >
> > testing
> >
> > > results?  Does it help them to show them varying numbers of entries?
> > >
> > > On Tuesday 07 February 2006 1:27 pm, Jason Weisberger wrote:
> > > > Allows the user to display the selected amount of testing results.
> > > >
> > > > Changelog: include/testResults.php
> > > >
> > > > Index: appdb/include/testResults.php
> >
> > ===================================================================
> >
> > > > RCS file: /home/wine/appdb/include/testResults.php,v
> > > > retrieving revision 1.9
> > > > diff -u -r1.9 testResults.php
> > > > --- appdb/include/testResults.php    28 Jan 2006
> >
> > 22:53:28 -0000    1.9
> >
> > > > +++ appdb/include/testResults.php    7 Feb 2006
> >
> > 18:23:52 -0000
> >
> > > > @@ -349,23 +349,25 @@
> > > >      // Show the Test results for a application version
> > > >      function ShowVersionsTestingTable($iVersionId,
> >
> > $iCurrentTest, $link,
> >
> > > > $iDisplayLimit)
> > > >      {
> > > > -        $showAll = $_REQUEST['showAll'];
> > > > +    $iDisplayLimit = $_REQUEST['iDisplayLimit'];
> > > > +
> > >
> > > Do you really want to override the display limit passed into the
> > > function?
> > >
> > > > -        echo '<form method=get action="'.$PHP_SELF.'">';
> > > > -        echo '<input name="versionId" type=hidden
> >
> > value="',$iVersionId,'"
> >
> > > > />';
> > > > -        if($rowsUsed >= $iDisplayLimit && !is_string($showAll))
> > > > -            echo '<input class="button" name="showAll" type=submit
> > > > value="Show All Tests" />';
> > > > +    echo '<form method=get action="'.$PHP_SELF.'">';
> > > > +    echo '<input name="versionId" type=hidden
> > > > value="',$iVersionId,'"
> >
> > />';
> >
> > > > +    if($rowsUsed >= 5) {
> > > > +        echo 'Tests:<select name="iDisplayLimit">';
> > > > +            echo '<option value="5"'; if($iDisplayLimit == 5) { echo
> > > > ' selected="selected"';} echo '>5</option>';
> > > > +            echo '<option value="10"'; if($iDisplayLimit == 10) {
> > > > echo
> >
> > '
> >
> > > > selected="selected"';} echo '>10</option>';
> > > > +            echo '<option value="15"'; if($iDisplayLimit == 15) {
> > > > echo
> >
> > '
> >
> > > > selected="selected"';} echo '>15</option>';
> > > > +            echo '<option value="20"'; if($iDisplayLimit == 20) {
> > > > echo
> >
> > '
> >
> > > > selected="selected"';} echo '>20</option>';
> > > > +            echo '<option value="ALL"'; if($iDisplayLimit == "ALL")
> > > > {
> >
> > echo
> >
> > > > ' selected="selected"';} echo '>ALL</option>';
> > > > +            echo '</select>';
> > >
> > > You can use a for() loop to generate all of these entries.
> >
> > --
> > Jason Weisberger
> > jbdubbs at gmail.com