PATCH: AF_UNSPEC mapping

Marcus Meissner marcus at jet.franken.de
Mon Jan 2 05:52:58 CST 2006


Hi,

Into some functions you can pass in an "empty" sockaddr with AF_UNSPEC
set. So lets handle this kind of sockaddr too.

Also zero initialize the sockaddr in ws_sockaddr_alloc().

Ciao, Marcus

Changelog:
	Also map AF_UNSPEC sockaddrs in the sockaddr handlers.
	Zero initialize the sockaddr in ws_sockaddr_alloc().

Index: socket.c
===================================================================
RCS file: /home/wine/wine/dlls/winsock/socket.c,v
retrieving revision 1.204
diff -u -r1.204 socket.c
--- socket.c	12 Dec 2005 17:15:09 -0000	1.204
+++ socket.c	2 Jan 2006 11:25:56 -0000
@@ -900,7 +900,7 @@
  * start with. Note that the returned pointer may be the original pointer
  * if no conversion is necessary.
  */
-static const struct sockaddr* ws_sockaddr_ws2u(const struct WS_sockaddr* wsaddr, int wsaddrlen, unsigned int *uaddrlen)
+static struct sockaddr* ws_sockaddr_ws2u(const struct WS_sockaddr* wsaddr, int wsaddrlen, unsigned int *uaddrlen)
 {
     switch (wsaddr->sa_family)
     {
@@ -924,7 +924,7 @@
 #ifdef IPX_FRAME_NONE
             uipx->sipx_type=IPX_FRAME_NONE;
 #endif
-            return (const struct sockaddr*)uipx;
+            return (struct sockaddr*)uipx;
         }
 #endif
     case WS_AF_INET6: {
@@ -943,7 +943,7 @@
             uin6->sin6_port     = win6old->sin6_port;
             uin6->sin6_flowinfo = win6old->sin6_flowinfo;
             memcpy(&uin6->sin6_addr,&win6old->sin6_addr,16); /* 16 bytes = 128 address bits */
-            return (const struct sockaddr*)uin6;
+            return (struct sockaddr*)uin6;
         }
         if (wsaddrlen>=sizeof(struct WS_sockaddr_in6)) {
             *uaddrlen=sizeof(struct sockaddr_in6);
@@ -953,7 +953,7 @@
             uin6->sin6_flowinfo = win6->sin6_flowinfo;
             uin6->sin6_scope_id = win6->sin6_scope_id;
             memcpy(&uin6->sin6_addr,&win6->sin6_addr,16); /* 16 bytes = 128 address bits */
-            return (const struct sockaddr*)uin6;
+            return (struct sockaddr*)uin6;
         }
         FIXME("bad size %d for WS_sockaddr_in6\n",wsaddrlen);
         return NULL;
@@ -969,7 +969,26 @@
         uin->sin_family = AF_INET;
         uin->sin_port   = win->sin_port;
         memcpy(&uin->sin_addr,&win->sin_addr,4); /* 4 bytes = 32 address bits */
-        return (const struct sockaddr*)uin;
+        return (struct sockaddr*)uin;
+    }
+    case WS_AF_UNSPEC: {
+        /* Try to determine the needed space by the passed windows sockaddr space */
+        switch (wsaddrlen) {
+        default: /* likely a ipv4 address */
+        case sizeof(struct WS_sockaddr_in):
+            *uaddrlen = sizeof(struct sockaddr_in);
+            break;
+#ifdef HAVE_IPX
+        case sizeof(struct WS_sockaddr_ipx):
+            *uaddrlen = sizeof(struct sockaddr_ipx);
+            break;
+#endif
+        case sizeof(struct WS_sockaddr_in6):
+        case sizeof(struct WS_sockaddr_in6_old):
+            *uaddrlen = sizeof(struct sockaddr_in6);
+            break;
+        }
+        return HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,*uaddrlen);
     }
     default:
         FIXME("Unknown address family %d, return NULL.\n", wsaddr->sa_family);
@@ -995,7 +1014,7 @@
     else
         *uaddrlen=max(sizeof(struct sockaddr),*wsaddrlen);
 
-    return HeapAlloc(GetProcessHeap(), 0, *uaddrlen);
+    return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, *uaddrlen);
 }
 
 /* Returns 0 if successful, -1 if the buffer is too small */
@@ -1083,6 +1102,10 @@
         *wsaddrlen = sizeof(struct WS_sockaddr_in);
         return 0;
     }
+    case AF_UNSPEC: {
+        memset(wsaddr,0,*wsaddrlen);
+        return 0;
+    }
     default:
         FIXME("Unknown address family %d\n", uaddr->sa_family);
         return -1;



More information about the wine-patches mailing list