OLEAUT32: Revert back to an older more informative error message.

Mike McCormack mike at codeweavers.com
Tue Jan 3 04:00:15 CST 2006


Many installers cause Wine's oleaut32 to output alot of FIXME messages 
like this:

fixme:ole:_copy_arg Should not use VariantChangeType here. (conversion 
from 0x4003 -> 0xb) 0000ffff

This message is somewhat frustrating, as although it warns of a 
potential problem, it provides no insight into the solution.

I found the patch that introduced the problem (using git):

git-whatchanged -p -C -S'Should not use VariantChangeType'
commit hash -> 49eaa0db2b3f7443ead40ef4a5d5b3d650c11384

It removed an (IMO) slightly more useful message:

"argument was coerced in-place (0x%x -> 0x%x); source data has been 
modified!!!\n"

Can anybody help suggest the real way to fix the problem?  Is it that we 
have to make a copy of the args array before modifying it?  Maybe we can 
put a comment in the code about how to fix it, some somebody looking at 
it in the future will know how to solve it right?

thanks,

Mike


ChangeLog:
Revert back to a more informative error message.

  dlls/oleaut32/typelib.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 4961982cf79a38138cfc42487a4ed6957b2667c3.diff
Type: text/x-patch
Size: 651 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060103/6f829f14/4961982cf79a38138cfc42487a4ed6957b2667c3-0001.diff


More information about the wine-patches mailing list