PATCH: msi / start command errors

Marcus Meissner marcus at jet.franken.de
Tue Jan 3 09:35:31 CST 2006


Hi,

Report better errors when we are not able to start
programs.

Ciao, Marcus

Changelog:
	Report the commandline that failed to start in ERR()s.

Index: custom.c
===================================================================
RCS file: /home/wine/wine/dlls/msi/custom.c,v
retrieving revision 1.31
diff -u -r1.31 custom.c
--- dlls/msi/custom.c	10 Nov 2005 12:14:58 -0000	1.31
+++ dlls/msi/custom.c	3 Jan 2006 15:34:26 -0000
@@ -548,13 +548,14 @@
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
 
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action, 
                           &finished);
@@ -609,13 +610,14 @@
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
     
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action, 
                          NULL);
@@ -694,13 +696,14 @@
     rc = CreateProcessW(NULL, cmd, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
 
-    msi_free(cmd);
     
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(cmd));
+        msi_free(cmd);
         return ERROR_SUCCESS;
     }
+    msi_free(cmd);
 
     return process_handle(package, type, info.hThread, info.hProcess, action, NULL);
 }
@@ -733,13 +736,14 @@
 
     rc = CreateProcessW(NULL, deformated, NULL, NULL, FALSE, 0, NULL,
                   c_collen, &si, &info);
-    msi_free(deformated);
 
     if ( !rc )
     {
-        ERR("Unable to execute command\n");
+        ERR("Unable to execute command %s\n", debugstr_w(deformated));
+        msi_free(deformated);
         return ERROR_SUCCESS;
     }
+    msi_free(deformated);
 
     prc = process_handle(package, type, info.hThread, info.hProcess, action,
                          NULL);



More information about the wine-patches mailing list