[AppDB] Fix Screenshots on windows IE 6 and others

Chris Morgan chmorgan at gmail.com
Sat Jul 1 15:50:07 CDT 2006


Good catch.  I didn't notice this during testing with ff >=1.5.  I'll
add a unit test that will call the output function, that should reveal
the use of an undefined variable.  Too bad php's lint option doesn't
actually check this stuff.

Chris



On 7/1/06, Tony Lambregts <tony.lambregts at gmail.com> wrote:
> My was testing out the AppDB on several different browsers and I had
> some problems with them that this patch fixes.
>
> Windows XP Home edition.
> ==========
> IE 6 sp2
> * http://appdb.winehq.org/viewScreenshots.php would not display thumbnails
>
> Firefox 1.07
> * http://appdb.winehq.org/viewScreenshots.php did display thumbnails but
> appimage.php does not open a new window
> the java console finds this error.
> Error: syntax error
> Source Code:
> javascript:openWin('./appimage.php?id=52','ttzqd',,4);return false;
>
>
> Fedora Core 4
> ==========
> SeaMonkey/1.0
> * http://appdb.winehq.org/viewScreenshots.php did display thumbnails but
> appimage.php does not open a new window
>
> Konqueror 3.4.0-5
> * Side and bottom bars obscure bottom and side of screenshot in appimage.php
>
> Firefox 1.04
> * http://appdb.winehq.org/viewScreenshots.php did display thumbnails but
> appimage.php does not open a new window
>
> ==========
> The cause of this is  this patch http://cvs.winehq.org/patch.py?id=26155
>
> One final note for some reason IE 6.2 always wants to display the
> sidebar so I needed to increase the width  to show the image properly.
>
> I increased the height for similar reasons in Konqueror
>
> Change Log:  Fix height an width of images
>
> Files Changed: include/screenshot php
>
>
>
>
>
>



More information about the wine-patches mailing list