[AppDB] - fix variable naming of preferences/account related
variables
Chris Morgan
cmorgan at alum.wpi.edu
Tue Jul 4 19:42:51 CDT 2006
This patch is likely to be a subset of Jon's patch to rename all of the
$_REQUEST variable names. My apologies for conflicting with this patch but
any reduction in its size is likely a good thing at this point. Our unit
test coverage is so sparse we can't be sure if a wholesale rename like Jon
proposed will break anything. Rather than use the orignal names I changed
them to match what is used inside of the user class which imo are easier to
understand than the previous names that were used.
Jon, you'll want to rediff from the directory you made your patch to remove
the overlapping changes from your patch and reduce its size. Once I hear
back from you about my other email we can look at either waiting until more
unit tests are in place or just putting the rename in after a more careful
review.
Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_ext_variable_naming.patch
Type: text/x-diff
Size: 12787 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060704/783243ce/fix_ext_variable_naming-0001.patch
More information about the wine-patches
mailing list