shell: Misplacement of SHIsFileAvailableOffline

Pierre d'Herbemont pdherbemont at free.fr
Fri Jul 7 07:38:18 CDT 2006


Hi,

this fix this issue on non x86:

../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./ 
shell32.spec authors.o autocomplete.o brsfolder.o changenotify.o  
classes.o clipboard.o control.o cpanelfolder.o dde.o dataobject.o  
debughlp.o dialogs.o dragdrophelper.o enumidlist.o folders.o  
iconcache.o pidl.o regsvr.o shell32_main.o shelllink.o shellole.o  
shellord.o shellpath.o shellreg.o shellstring.o shfldr_desktop.o  
shfldr_fs.o shfldr_mycomp.o shfldr_unixfs.o shlexec.o shlfileop.o  
shlfolder.o shlfsbind.o shlmenu.o shlview.o shpolicy.o shv_bg_cmenu.o  
shv_item_cmenu.o systray.o  shres.res    -o shell32.dll.so -L../../ 
dlls -lole32 -loleaut32 -lshlwapi -lcomctl32 -luser32 -lgdi32 - 
ladvapi32 -lkernel32 -lntdll -Wb,-dole32 -Wb,-doleaut32 -L../../libs - 
lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port - 
lwine_port  -lresolv -lpoll
./shell32.spec:362: function 'SHIsFileAvailableOffline' not defined

Which is due to the fact that SHIsFileAvailableOffline is defined as  
part of the 32 lib in shell32.spec, and implemented in the 16 part.

Thanks,

Pierre.

ChangeLog
move SHIsFileAvailableOffline from shell.c to shlfileop.c to ensure  
the 16/32 bits separation.
-------------- next part --------------
diff --git a/dlls/shell32/shell.c b/dlls/shell32/shell.c
index c8a78f8..533ccdb 100644
--- a/dlls/shell32/shell.c
+++ b/dlls/shell32/shell.c
@@ -86,12 +86,6 @@ BOOL WINAPI SHELL_DllEntryPoint(DWORD Re
     return TRUE;
 }
 
-HRESULT WINAPI SHIsFileAvailableOffline(LPCWSTR path, LPDWORD status)
-{
-    FIXME("(%s, %p) stub\n", debugstr_w(path), status);
-    return E_FAIL;
-}
-
 /*************************************************************************
  *				DragAcceptFiles		[SHELL.9]
  */
diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c
index 49fa995..977e301 100644
--- a/dlls/shell32/shlfileop.c
+++ b/dlls/shell32/shlfileop.c
@@ -151,6 +151,12 @@ static void SHELL32_FreeUnicodeBuf(LPWST
 	HeapFree(GetProcessHeap(), 0, wPath);
 }
 
+HRESULT WINAPI SHIsFileAvailableOffline(LPCWSTR path, LPDWORD status)
+{
+    FIXME("(%s, %p) stub\n", debugstr_w(path), status);
+    return E_FAIL;
+}
+
 /**************************************************************************
  * SHELL_DeleteDirectory()  [internal]
  *


More information about the wine-patches mailing list