[AppDB] Sort test results

[Tony Lambregts]

Chris Morgan wrote:
> On Saturday 08 July 2006 4:27 pm, Tony Lambregts wrote:
>   
>> This patch is meant to start a discussion more than anything else. We
>> currently have no way of sorting test results in a reasonable order. If we
>> sort by testedRating the order is not what we want. IE: Bronze, Garbage,
>> Gold, Platinum and Silver.
>>
>> It might be better in the long run to replace testedRating in testResults
>> with ratingId. That however is a fairly big project.
>>
>> (You need to run the table/testRating.sql script in mysql to test this
>> patch out.)
>>
>> Change Log: Sort test results by rating in distributions
>>
>> Files Changed: include/distributions.php
>>
>> New File: tables/testRating.sql
>>     
>
>
> I think this change makes sense.  It allows us to get away with not having to 
> monkey with the existing table although I wonder if we changed to using an 
> enum and put the highest rating first in the enum, would that also work?  
> That might be nearly as easy to do.
>
>   
Now thats why I asked... Yes that works much better. Run the following 
sql and the attached  patch works the way it should.

ALTER TABLE testResults MODIFY testedRating 
enum('Platinum','Gold','Silver','Bronze','Garbage') NOT NULL;

Change Log: Sort test results by rating in distributions

Files Changed: 
   include/distributions.php
  tables/testResults.sql




-------------- next part --------------
A non-text attachment was scrubbed...
Name: testRating.diff
Type: text/x-patch
Size: 2012 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060708/1d7e48b3/testRating.diff