[AppDB] - speed up outputTopXRowAppsFromRating()

Chris Morgan cmorgan at alum.wpi.edu
Tue Jul 11 07:59:21 CDT 2006


On Tuesday 11 July 2006 2:19 am, Jonathan Ernst wrote:
> Le lundi 10 juillet 2006 à 15:33 -0400, Chris Morgan a écrit :
> > If we have found enough applications for our required top X list we
> > should early out instead of issuing another database query with a limit
> > of 0.
> >
> > Also rename $num_apps to $iNum_apps.
>
> - This doesn't follow our coding standards.

You are correct.  I'll fix this when I rename the function.


> - Also the comments you added don't follow it too.

You mean the single line ones?  I"m not sure we should be so restrictive on 
the format of those between /* comment */ and // comment



> - In a next patch this function should be renamed to
> util_output_top_rated_apps($rating, $iNum_apps) for example

Yes.  I wasn't going to rename in the same patch.


Chris



More information about the wine-patches mailing list