[comctl32] Use structmember after check for NULL (Coverity) (RESEND)
Paul Vriens
Paul.Vriens at xs4all.nl
Sat Jul 15 13:27:24 CDT 2006
This time without the html attachment (I hope). Have to figure out what
goes wrong with editing draft messages in Evolution.
===
Hi,
just a simple one (as suggested by Rob). For consistency sake we should
use a
structmember after we've checked for NULL (not before).
Satisfies Coverity CID-654.
Changelog
Use structmember after check for NULL
Cheers,
Paul.
---
dlls/comctl32/listview.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index fb4ecf6..4d3819d 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -5618,10 +5618,12 @@ static BOOL LISTVIEW_GetSubItemRect(LIST
{
POINT Position;
LVITEMW lvItem;
- INT nColumn = lprc->top;
+ INT nColumn;
if (!lprc) return FALSE;
+ nColumn = lprc->top;
+
TRACE("(nItem=%d, nSubItem=%ld)\n", nItem, lprc->top);
/* On WinNT, a subitem of '0' calls LISTVIEW_GetItemRect */
if (lprc->top == 0)
--
1.4.1
More information about the wine-patches
mailing list