[WINED3D] Resend, Bugfix: Do not return WINED3DERR_INVALIDCALL for Phong shading.

Ivan Gyurdiev ivg231 at gmail.com
Thu Jul 20 22:04:18 CDT 2006


MSDN says Phong shading is "not supported", but native does not return 
INVALIDCALL like we do. Print a FIXME and continue.

Uncovered by stateblock test patch.
-------------- next part --------------
---

 dlls/wined3d/device.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

db63f42a17d7195ce7651ecb5915b41833ee1c6a
diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index fb7e084..babbb9b 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -3491,10 +3491,8 @@ static HRESULT WINAPI IWineD3DDeviceImpl
             checkGLcall("glShadeModel");
             break;
         case D3DSHADE_PHONG:
-            FIXME("D3DSHADE_PHONG isn't supported?\n");
-
-            LEAVE_GL();
-            return WINED3DERR_INVALIDCALL;
+            FIXME("D3DSHADE_PHONG isn't supported\n");
+            break;
         default:
             FIXME("Unrecognized/Unhandled D3DSHADEMODE value %ld\n", Value);
         }
-- 
1.3.3



More information about the wine-patches mailing list