Fix bug#5475 : File Open Dialog

renu.rajput at tcs.com renu.rajput at tcs.com
Fri Jul 28 06:52:07 CDT 2006


Bugzilla Bug 5475
Control isnt transferred in the function CFileDialog::OnFolderChange()
incase of Customized file open dialog

Bug Description
The problem is this: CFileDialog has a built in function called
OnFolderChange, that is used to determine whether the user has changed
folders in the dialog, whether by double click or what not.. the program
i'm working on overrides the CFileDialog class, and includes more code for
the OnFolderChange function (and for other functions) for its own purposes.
the new OnFolderChange function works perfectly fine in windows, but is
completely ignored when using wine - it never even gets called, while the
rest of the dialog window retains all of its intended functionality.

ChangeLog
Send the CDN_FOLDERCHANGE message when browsing a folder.

Test case
Same exe as uploaded with the bug description is attached herewith.

Following patch generated against Wine version 0.9.18 in file:

 /dlls/comdlg32/filedlg.c
@@ -2022,7 +2022,10 @@
           IPersistFolder2_Release(ppf2);
        if( ! COMDLG32_PIDL_ILIsEqual(pidlCurrent,
fodInfos->ShellInfos.pidlAbsCurrent))
        {
-         IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser,
pidlCurrent, SBSP_ABSOLUTE);
+           if
(SUCCEEDED(IShellBrowser_BrowseObject(fodInfos->Shell.FOIShellBrowser,
pidlCurrent, SBSP_ABSOLUTE)))
+           {
+                 SendCustomDlgNotificationMessage(hwnd, CDN_FOLDERCHANGE);
+           }
        }
        else if( nOpenAction == ONOPEN_SEARCH )
        {

Attachments:
Patch.diff
mfctest.exe - For test case

Thanks
Renu Rajput
email: renu.rajput at tcs.com


 (See attached file: patch.diff)(See attached file: mfctest.zip)
=====-----=====-----=====
Notice: The information contained in this e-mail
message and/or attachments to it may contain 
confidential or privileged information. If you are 
not the intended recipient, any dissemination, use, 
review, distribution, printing or copying of the 
information contained in this e-mail message 
and/or attachments to it are strictly prohibited. If 
you have received this communication in error, 
please notify us by reply e-mail or telephone and 
immediately and permanently delete the message 
and any attachments. Thank you


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 500 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060728/b6885b61/patch-0001.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mfctest.zip
Type: application/zip
Size: 31053 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20060728/b6885b61/mfctest-0001.zip


More information about the wine-patches mailing list