wined3d: Don't refcount in getter functions.

Markus Amsler markus.amsler at oribi.org
Tue Nov 21 19:57:13 CST 2006


This removes AddRef calls from all getters, except GetParent, which 
addrefs on d3dx objects not wined3d. It also removes refcounting in 
QueryInterface (also some sort of getter).

AddRef in wined3d getters doesn't make sense, because the returned 
object always gets immediately released. And we don't refcount properly 
anyway.

If this is complete garbage please let me know, so i can stop working on it.
---
  dlls/d3d8/cubetexture.c          |    1 -
  dlls/d3d8/device.c               |    9 -------
  dlls/d3d8/pixelshader.c          |    1 -
  dlls/d3d8/resource.c             |    1 -
  dlls/d3d8/surface.c              |    5 ----
  dlls/d3d8/swapchain.c            |    1 -
  dlls/d3d8/texture.c              |    1 -
  dlls/d3d8/vertexshader.c         |    1 -
  dlls/d3d8/volume.c               |    2 -
  dlls/d3d8/volumetexture.c        |    1 -
  dlls/d3d9/cubetexture.c          |    1 -
  dlls/d3d9/device.c               |    7 -----
  dlls/d3d9/pixelshader.c          |    2 -
  dlls/d3d9/query.c                |    1 -
  dlls/d3d9/resource.c             |    1 -
  dlls/d3d9/surface.c              |    1 -
  dlls/d3d9/swapchain.c            |    3 --
  dlls/d3d9/texture.c              |    1 -
  dlls/d3d9/vertexdeclaration.c    |    2 -
  dlls/d3d9/vertexshader.c         |    2 -
  dlls/d3d9/volume.c               |    2 -
  dlls/d3d9/volumetexture.c        |    1 -
  dlls/ddraw/ddraw.c               |    3 --
  dlls/ddraw/device.c              |    1 -
  dlls/wined3d/basetexture.c       |    1 -
  dlls/wined3d/cubetexture.c       |    2 -
  dlls/wined3d/device.c            |   47 
+------------------------------------
  dlls/wined3d/directx.c           |    1 -
  dlls/wined3d/drawprim.c          |    2 -
  dlls/wined3d/indexbuffer.c       |    1 -
  dlls/wined3d/palette.c           |    1 -
  dlls/wined3d/pixelshader.c       |    2 -
  dlls/wined3d/query.c             |    2 -
  dlls/wined3d/resource.c          |    2 -
  dlls/wined3d/stateblock.c        |    4 +--
  dlls/wined3d/surface.c           |   25 +------------------
  dlls/wined3d/swapchain.c         |    8 ------
  dlls/wined3d/texture.c           |    2 -
  dlls/wined3d/vertexbuffer.c      |    1 -
  dlls/wined3d/vertexdeclaration.c |    2 -
  dlls/wined3d/vertexshader.c      |    2 -
  dlls/wined3d/volume.c            |    1 -
  dlls/wined3d/volumetexture.c     |    2 -
  43 files changed, 5 insertions(+), 154 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: a49058020ec8abc6f0f0baf2354e0ca072e2b364.diff
Type: text/x-patch
Size: 49812 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-patches/attachments/20061122/18d1d09d/a49058020ec8abc6f0f0baf2354e0ca072e2b364-0001.bin


More information about the wine-patches mailing list